3
Allow can-i-deploy to run without returning an error code
complete
Activity Feed
Sort by
Beth
complete
Beth
If anyone wants to provide feedback on the way to display this in the console, I have some options in the slack workspace here: https://pact-foundation.slack.com/archives/C5F4KFKR8/p1621117112349600
Simon
Beth How about PACT_BROKER_CAN_I_DEPLOY_DRY_RUN?
Beth
Simon: I had a think about that too actually. I feel like a dry run is for when there's a side effect, and there's no side effect for can-i-deploy. It feels more like a vulnerability scanner, where you can say "I just want to see the issues, but keep going with the build". PACT_BROKER_CAN_I_DEPLOY_WARN_ON_FAILURE=true ?
Simon
Beth: Isn't a failed exit code the side effect?
Beth
Simon: yeah, I guess it is.
Joaquin Campero
Beth: I feel that WARN_ON_FAILURE talks more about the logging that the return code...
PACT_BROKER_CAN_I_DEPLOY_EXIT_ON_FAILURE=false ?
or
PACT_BROKER_CAN_I_DEPLOY_SKIP_FAILURES=true ?